Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolbaroptions should be better declared #25

Closed
Waxolunist opened this issue Dec 20, 2013 · 1 comment
Closed

Toolbaroptions should be better declared #25

Waxolunist opened this issue Dec 20, 2013 · 1 comment
Assignees
Milestone

Comments

@Waxolunist
Copy link
Owner

The toolbaroptions are currently read in the root of the options. The disadvantage of this approach is, that it is not possible to declare more granular options. Besides it is bad, because it does not allow to declare other options of type boolean and value true.

Goal is that toolbaroptions are an object of its own. Every non falsy value should initiate the corresponding menu.

This change will break current approach, therefore it is in version 0.3.x.

@ghost ghost assigned Waxolunist Dec 20, 2013
@Garito
Copy link
Collaborator

Garito commented Dec 20, 2013

Let's try to make it as minimalist as possible, though

Waxolunist added a commit that referenced this issue Dec 20, 2013
The option emSmall is now in empahasis.small.
Optionshandling just got easier.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants