Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label button (WIP) #18

Closed
wants to merge 1 commit into from
Closed

Conversation

Garito
Copy link
Collaborator

@Garito Garito commented Dec 18, 2013

Added a button to make the selection a Bootstrap Label
Despiste the fact that the code it's based on the Link button, the
behavior differs on the link when the label is already setted (this is
why is a WIP)

Added the needed locales for en-US, es-ES and ca-CT

Added a button to make the selection a Bootstrap Label
Despiste the fact that the code it's based on the Link button, the
behavior differs on the link when the label is already setted (this is
why is a WIP)

Added the needed locales for en-US, es-ES and ca-CT
@Garito
Copy link
Collaborator Author

Garito commented Dec 18, 2013

I hope I'm doing this in the correct way

@Waxolunist
Copy link
Owner

I added you as a collaborator, thus I can assign you issues too. But I would be thankful, if you would still keep in pull request mode.
I just started some planning and thoughts about refactoring the code, so it is eligible for new features, because the code as forked is hard to maintain (1 file to rule em all). So please be patient.

@Waxolunist
Copy link
Owner

I also started a wiki. You can edit the pages there if you think something is worth documenting.

@Garito
Copy link
Collaborator Author

Garito commented Dec 19, 2013

Thanks for giving me pull rights but I'm super agree with you: I prefer pull request
Perhaps I will merge directly in the future if necessary but giving the fact that I'm an absolutely newbie I don't wanna mess up anything

I'm at your orders so I don't allow you assign me tasks, I ask you for, please :D

@Waxolunist
Copy link
Owner

I have pulled it to my laptop. At first sight it looks good. But you see it's something going on in the wiki and in the code base.
I will pull it or make a suggestion when I am clear about how the code should be organized.
You can take over tasks, if you want to. I have no problems with sharing.

@Waxolunist
Copy link
Owner

Definitely not a 0.2 feature. Moving to 0.3

@ghost ghost assigned Garito and Waxolunist Dec 19, 2013
@Garito
Copy link
Collaborator Author

Garito commented Dec 19, 2013

Cool... I've seen 2 ways to create actions: by a command (like the new small) and like link or formatInline or even the one to insert html

As you ask for patience to decide something I want to check the wysihtml5 fork you told me and try to understand better (now I mostly move by intuition)

@Waxolunist Waxolunist modified the milestones: v0.3.1 (current development), v0.3.0, v0.4.0 (not planned yet) Jun 11, 2014
@Waxolunist Waxolunist closed this Sep 7, 2014
@Waxolunist
Copy link
Owner

Sorry, this is definitely not the direction I want to go. I will close this and others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants