Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gtk-shell to newest version #1834

Closed
manfred3000 opened this issue Jul 25, 2023 · 5 comments
Closed

Update gtk-shell to newest version #1834

manfred3000 opened this issue Jul 25, 2023 · 5 comments
Labels
easy Issues that do not require knowledge about the whole codebase good first issue plugins

Comments

@manfred3000
Copy link

manfred3000 commented Jul 25, 2023

Describe the bug
The binaries provided by wl-clipboard v2.2 produce an error without copying/pasting anything (see output below)

To Reproduce
Steps to reproduce the behavior:

~ ls . | wl-copy 2>wl-copy.log
~ cat wl-copy.log
wl_registry@2: error 0: invalid version for global gtk_shell1 (39): have 3, wanted 4
wl_display_dispatch: Protocol error
~ wl-paste 2>wl-paste.log 
~ cat wl-paste.log
wl_registry@2: error 0: invalid version for global gtk_shell1 (39): have 3, wanted 4
wl_display_dispatch: Protocol error

Expected behavior
wl-copy and wl-paste copy/paste contents from clipboard (still working with e.g. compositor sway v1.8.1)

Wayfire version

~ wayfire -vvv
0.7.5
@manfred3000
Copy link
Author

The issue doesn't seem to be present anymore in master

@K14D
Copy link

K14D commented Aug 14, 2023

Is this confirmed to work with master? It seems like wl-clipboard needs gtk-shell 4 and wayfire (master) still provides gtk-shell 3.

@manfred3000
Copy link
Author

manfred3000 commented Aug 15, 2023

Actually you're right. I did some more "testing" and it turned out that by using my old config, which doesn't enable the gtk-shell plugin yet, wl-clipboard is working as expected. I can still reproduce if I load the gtk-shell plugin.
Re-opening...

https://github.com/search?q=repo%3AWayfireWM%2Fwayfire%20gtk-shell&type=code

@manfred3000 manfred3000 reopened this Aug 15, 2023
@ammen99
Copy link
Member

ammen99 commented Aug 15, 2023

IMO wl-clipboard should fix this. I don't see why it should refuse to work with older versions of gtk-shell (since the gtk-shell functionality is optional in the first place!). Consider opening an issue there as well, so that they can fix this.

@ammen99 ammen99 changed the title Changes in 'wl-clipboard' v2.2 not supported in 'wayfire' v0.7.5 Update gtk-shell to newest version Aug 15, 2023
@ammen99 ammen99 added easy Issues that do not require knowledge about the whole codebase plugins good first issue and removed bug labels Aug 15, 2023
@manfred3000
Copy link
Author

manfred3000 commented Aug 15, 2023

Since I'm not using gtk-shell and upstream apparently fixed the issue, I'm closing this for good...

EDIT: @ammen99 Sorry, I didn't realize you already removed the bug label - please do with this issue whatever suits your workflow.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy Issues that do not require knowledge about the whole codebase good first issue plugins
Projects
None yet
Development

No branches or pull requests

3 participants