Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

panel: Implement default logout user interface #100

Merged
merged 1 commit into from Sep 22, 2021
Merged

panel: Implement default logout user interface #100

merged 1 commit into from Sep 22, 2021

Conversation

soreau
Copy link
Member

@soreau soreau commented Jul 14, 2021

When a user clicks the logout button in the menu and no command is set,
open a default logout interface.

@soreau
Copy link
Member Author

soreau commented Jul 14, 2021

screenshot

@soreau soreau force-pushed the logout-ui branch 2 times, most recently from 2c7f28d to c89968d Compare July 16, 2021 04:51
@ammen99
Copy link
Member

ammen99 commented Jul 16, 2021

The idea looks good. However: should we not present the window as a layer-shell overlay on top of everything? I think this is the default in other DEs, but please correct me if I'm wrong.

@soreau
Copy link
Member Author

soreau commented Jul 16, 2021

The idea looks good. However: should we not present the window as a layer-shell overlay on top of everything? I think this is the default in other DEs, but please correct me if I'm wrong.

The way it is currently, the logout UI can be minimized or closed and other views can occlude it, and it calls gtk-window-present to unminimize and/or raise the view if it the logout button is clicked again. This is perfectly sane behavior to me. What are the benefits to having it a layer-shell always-on-top view that differ from this behavior?

@soreau soreau force-pushed the logout-ui branch 2 times, most recently from c236ee2 to 7b2ccac Compare August 15, 2021 04:00
When a user clicks the logout button in the menu and no command is set,
open a default logout interface.
Copy link
Member

@ammen99 ammen99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks cool, thanks!

@ammen99 ammen99 merged commit 8d1f962 into master Sep 22, 2021
@ammen99 ammen99 deleted the logout-ui branch September 22, 2021 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants