Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add custom labels on launchers from cmd+icon combo #51

Merged
merged 5 commits into from
May 3, 2020
Merged

Add custom labels on launchers from cmd+icon combo #51

merged 5 commits into from
May 3, 2020

Conversation

mpolosak
Copy link
Contributor

@mpolosak mpolosak commented Apr 17, 2020 •
edited by ammen99

I've started working on panel launchers: custom labels on launchers from cmd+icon combo

Fixes #6

@mpolosak mpolosak marked this pull request as ready for review April 17, 2020 15:09
@mpolosak
Copy link
Contributor Author

Done ready for review

@mpolosak mpolosak mentioned this pull request Apr 22, 2020
Closed
ammen99
ammen99 requested changes May 2, 2020
View reviewed changes
Copy link
Member

@ammen99 ammen99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few style issues, but LGTM overall.

src/panel/widgets/launchers.cpp Show resolved Hide resolved
src/panel/widgets/launchers.cpp Outdated Show resolved Hide resolved
ammen99
ammen99 approved these changes May 3, 2020
View reviewed changes
Copy link
Member

@ammen99 ammen99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ammen99 ammen99 merged commit 0ae02ab into WayfireWM:master May 3, 2020
@mpolosak mpolosak deleted the launchers_labels branch May 3, 2020 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ammen99 ammen99 ammen99 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

panel launchers: custom labels on launchers from cmd+icon combo
2 participants
@mpolosak @ammen99