Time limit options applies to send and receive transfers #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stop-at, stop-after and time-limit options must be transfer direction agnostic, and must apply to rsync in receiver or sender mode.
|
This patch appears to work. Previously, rsync 3.2.3 would simply hang, as reported in #177, with this patch, it exits as expected: For completeness, this is what used to happen with 3.1.3: Thank you very much! |
|
Hi @WayneD , do you plan to integrate this fix in a future release ? |
freebsd-git
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
May 7, 2021
In latest version, upstream project breaks time limit options implementation. The fix allows the use of this option in both receiver and sender mode. A merger request was submitted to upstream project[1] but not yet merged. Bump portrevision. [1] RsyncProject/rsync#179 Reported by: philip Tested by: philip
|
Gently prodding here. We've been using this patch in production without a problem since April. |
|
Thanks! Sorry for the huge delay. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stop-at, stop-after and time-limit options must be transfer
direction agnostic, and must apply to rsync in receiver
or sender mode.