Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
init a Vec with
vec![]
is much faster thanfor_each
(10 times).and there is a
remove(0)
on Vec, it's very slow, use Deque is better.the bench of the deque and vec
result, 117.59ps vs 888180ps
the bench code of vec init way:
result, 22ns vs 209ns
btw, maybe you can try "early return", bc the indent of the
Terminal::render
is so much.and programming such a particle system is wonderful, i would think make a braille code version in rsille