Fix missing channels #24
Open
+930
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this is great, also bumping the node version, so that other people can clone this more confidently |
aredridel
approved these changes
Jul 19, 2020
|
This looks good as far as what's changed — did you spend any time looking at other things affected by the slack module upgrade? |
I didn't specifically review API changes but I do know we ran / are running this modification in production on our local slack with no issues. I'm no longer at the company but as of December 2019 we had no issues with the bot with this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On our private instance we discovered that some channels were missing when we used
/list-private.After digging in I found that the groups api was deprecated in favor of conversations. I fixed it to make it work, but for my own familiarity I bumped the node dependency version up to 10.x and used async/await. I hope that’s ok, or at least this can be a template for fixing the problem as you desire.