Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support ejs files #28

Merged
merged 2 commits into from
Apr 19, 2022
Merged

add support ejs files #28

merged 2 commits into from
Apr 19, 2022

Conversation

flockast
Copy link
Contributor

@flockast flockast commented Feb 23, 2021

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce?

The ability to use .ejs

  • What is the current behavior?

We can use only .html files

  • What is the new behavior (if this is a feature change)?

EJS have a lot of features in templates and this changes allow us to use it

  • Does this PR introduce a breaking change?

No it doesn't, everything works as before

  • Other information:

@pnikolov pnikolov self-assigned this Jan 30, 2022
@doodirock
Copy link

Was just about to ask if templates were possible. Would really complete the project to have support for templates. Any plans on a merge?

@pnikolov
Copy link
Member

pnikolov commented Mar 21, 2022

@flockast @doodirock I've resolved all merge conflicts and will approve this PR - adding support for .ejs files.
In order for adding a full support of .ejs template files do you think that adding ejs package as dependency and its configuration would be useful?

@pnikolov pnikolov self-requested a review March 29, 2022 13:00
@pnikolov pnikolov merged commit c2bf6c4 into WeAreAthlon:master Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants