Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change package name (causes signature conflict with Fairphone Open OS) #4

Closed
4 tasks done
Roboe opened this issue May 17, 2017 · 7 comments
Closed
4 tasks done

Comments

@Roboe
Copy link
Member

Roboe commented May 17, 2017

douwe at Fairphone Forum:

Hey all, one thing we noticed here at Fairphone: the package name of the app can not be the same as the original package for two reasons:

  • it will cause a conflict with the signature of our version of the app and the installation might fail.
  • people might get confused about the creator of these apps. So referencing Fairphone as the origin of this code is fine, but it should be clear it is a community (WeAreFairphone) project now.

Keep on pushing!

It has already caused troubles:
https://forum.fairphone.com/t/publishing-fairphone-specific-apps-launcher-contact-widget-on-f-droid/28008/54
https://forum.fairphone.com/t/my-contacts-widget-wont-update-wont-uninstall/28767 (related with how F-Droid manages cross-developer updates and erratic indications, though)

Steps to follow:

  • Remove WeAreFairphone apps with com.fairphone package namespace from F-Droid:
    • Release new virtual versions with a What's New section for each app
    • Disable current apps (docs)
  • Change package's namespace and resubmit them on F-Droid (metadata)

How should we do this? @jannispinter

@Roboe Roboe changed the title Change package name (causes signature conflict with FPoOS) Change package name (causes signature conflict with Fairphone Open OS) May 17, 2017
@jannispinter
Copy link
Member

jannispinter commented May 19, 2017

Changing the package's namespace and reupload shouldn't be a problem. F-Droid says that they don't remove apps. In this case however, they might make an exception. I will open a ticket at F-Droid.

Edit: Opened here.

@Roboe
Copy link
Member Author

Roboe commented May 22, 2017

So, steps to follow (updated above):

  • Release new virtual versions with a What's New section for each app
  • Disable current apps (docs)
  • Change signatures of apps. Add metadata for the "new apps" (i.e. submitting them on F-Droid)

@jannispinter
Copy link
Member

I'm a bit busy this week and might not be able to get this done until the weekend. Feel free to make the changes, if you have the spare time.

@Roboe
Copy link
Member Author

Roboe commented May 27, 2017

Update: https://gitlab.com/fdroid/fdroiddata/issues/736#note_30848046

I created new old-package-name branches for both apps and tried to setup the changelogs.
I will create tags and update F-Droid's metadata once we ensure this will work fine.

I will change package names now on the master branch and update tags to fit real version (this shouldn't break anything on F-Droid side).

Roboe added a commit that referenced this issue May 27, 2017
Roboe added a commit to WeAreFairphone/FP2-ClockWidget that referenced this issue May 27, 2017
Roboe added a commit to WeAreFairphone/FP2-Launcher that referenced this issue May 27, 2017
@Roboe
Copy link
Member Author

Roboe commented May 31, 2017

New apps had hit F-Droid. Old apps had been marked with a "deprecation notice". We only need to disable them in the next F-Droid index update. Will keep this issue open until then, ;)

@Roboe
Copy link
Member Author

Roboe commented Jun 21, 2017

I've submited last step needed to close this issue to F-Droid's data repo: https://gitlab.com/fdroid/fdroiddata/merge_requests/2339

@Roboe
Copy link
Member Author

Roboe commented May 28, 2018

Closing this since it was fulfilled time ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants