Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore default screen #16

Merged
merged 3 commits into from
May 20, 2018
Merged

Restore default screen #16

merged 3 commits into from
May 20, 2018

Conversation

Roboe
Copy link
Member

@Roboe Roboe commented May 19, 2018

This restores the default workspace (widgets and app launch icons) the Fairphone Launcher 3 came with.

The only difference is the Google Play launcher is now inside the Google folder and a F-Droid launcher is shown in its place, because our main distribution channel is F-Droid, not Google Play. This also solves the weird empty screen users without Google Mobile Services (a.k.a. GApps) installed felt in the first launch.

Also a related question: should we replace the Google Search widget with the Fairphone Clock widget? Follow the discussion in #18

@Roboe Roboe requested a review from Rudloff May 19, 2018 19:36
@Roboe Roboe mentioned this pull request May 19, 2018
@Rudloff
Copy link
Member

Rudloff commented May 19, 2018

I don't have any widget.
It might be because, by default, the launcher does not have permission to create widgets. (First time I add a widget, it asks me for permission.)

@Roboe
Copy link
Member Author

Roboe commented May 19, 2018

You need to clear previous data, I think. If you have the MyContacts app already installed, it will be added too.

@Rudloff
Copy link
Member

Rudloff commented May 19, 2018

I tried clearing the data and uninstalling/reinstalling the launcher. I never get any widget in the default view.
I can repoduce on Fairphone Open (Android 6.0.1) and AOSP 4.2.

@Roboe
Copy link
Member Author

Roboe commented May 19, 2018

Ok, will test this later today tomorrow

@Roboe
Copy link
Member Author

Roboe commented May 20, 2018

I can reproduce that in my FP2 (LOS 14.1), but my N4 (LOS 15.1) still create the widgets by default, even after uninstalling and reinstalling. I can't find where is the permissions to place widgets stored (I probably checked it in the past).

I'd have hoped that the launcher was able to place at least its own widgets without the explicit permission...

@Rudloff
Copy link
Member

Rudloff commented May 20, 2018

I think the permission is BIND_APPWIDGET but I don't really know how it works.
Maybe we could still merge this and firgure it out later?

Copy link
Member

@Rudloff Rudloff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for the widget issue, everything looks good.

@Roboe
Copy link
Member Author

Roboe commented May 20, 2018

Ok, let's merge this. I'll open a new since Workspace.java is 5500 lines long... 🤕

@Roboe Roboe merged commit 3103bfb into master May 20, 2018
@Roboe Roboe deleted the feature/restore-default-screen branch May 20, 2018 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants