Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump faraday requirement #214

Closed
Sapr0 opened this issue Feb 9, 2021 · 1 comment
Closed

Bump faraday requirement #214

Sapr0 opened this issue Feb 9, 2021 · 1 comment

Comments

@Sapr0
Copy link

Sapr0 commented Feb 9, 2021 •
edited
Loading

Newer chef-client (16.9.29+) come embedded with faraday 1.3.0 which breaks current diplomat gem due to the faraday < 1.1.0 requirement and makes it unable to use during a chef-run.

Can you release diplomat 3.0 major version with a higher faraday requirement and implicitly higher ruby requirement.
Whoever needs an old ruby can just pin the gem to the 2.4.4 version, after all that's why we use SemVer for versioning.

Also Ruby below 2.5 is EOL, yet an other reason to keep up with the newer versions of ruby/faraday
@pierresouchay
Copy link
Member

@Sapr0 Sure, can you propose a PR for that (I mean with the correct bumps and updated GEMs) ?

@Sapr0 Sapr0 mentioned this issue Feb 9, 2021
Merged
@ramereth ramereth mentioned this issue Feb 9, 2021
Closed
@Sapr0 Sapr0 closed this as completed Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Sapr0 @pierresouchay