Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump all gem dependencies #215

Merged
merged 5 commits into from
Feb 10, 2021
Merged

Bump all gem dependencies #215

merged 5 commits into from
Feb 10, 2021

Conversation

Sapr0
Copy link

@Sapr0 Sapr0 commented Feb 9, 2021

Addresses issue #214

lib/diplomat/version.rb Outdated Show resolved Hide resolved
@pierresouchay
Copy link
Member

@Sapr0 First of all: thanks a lot for this amazing contribution, pushing a lot the level of details.

I have just a few concerns:

  • we don't break the compatibility of the GEM (I mean API compatibility), so maybe a bump to 2.5.x would be enough (moreover, it fits nicely with being compatible with Ruby 2.5)
  • this is an old lib, and many users are using old versions of Ruby. I would like (as far as no security issues are found), to keep the ability for those users to avoid bumping too many versions of many libs, do you think it could be possible to minimize a bit the minimum versions bump? - I mean, is it possible to avoid bumping too much versions as long as we don't rely on new versions to avoid breaking too many users?

Thanks a lot for the contribution, I'll have a deeper look tomorrow (it is midnight here :-)

Regards

@Sapr0
Copy link
Author

Sapr0 commented Feb 10, 2021

Hi @pierresouchay

I've lowered the gem version to 2.5.0 as you wanted to match the ruby version.

Do you think it could be possible to minimize a bit the minimum versions bump?

Only faraday got bumped from 1.0.1 to 1.3.0
deep_merge already had a lose dependency via >= 1.0.1
I've removed json_pure, because the diplomat gem already had a requirement of ruby >= 2.0 so it would never install this gem

The rest are development dependencies, they are not taken into account when you install this gem.

@pierresouchay pierresouchay merged commit a3b5e37 into WeAreFarmGeek:master Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants