Resolve inconsistent recursive return for Diplomat::KV.get when singl… #120
Conversation
|
Not sure this is backward-compatible. I think it would break interface of non-recursive get. |
|
Yea I was thinking the same thing since it broke the spec tests and I would do a major version bump if/when this got merged. I am hoping to get the gem up to speed with the current API endpoints in Consul 0.7.2 ASAP before cutting a new release. |
|
This is so much needed, i would really love to see this getting fixed - major version bump is reasonable. Anything i can do to move this forward? Right now, i create dummy values in consul to avoid this bug... which is crazy |
|
@EugenMayer Well, quick workaround is to parse KV data yourself. |
|
@EugenMayer I just saw there was a major version bump in the past week, so I'm going to get this staged up and pushed out as 2.0.1 since I know this is really needed. In the next month or so, I plan to put some real TLC into this gem as I'll need it for an upcoming project. |
|
@EugenMayer I've rebased the changes onto the latest master branch, so if you could give this a quick +1 I'll move forward with getting this merged and released. |
|
i am so happy to have this one in, totally +1 |
|
@EugenMayer v2.0.1 has been tagged and released. enjoy! |
|
well this more or less has broken all diplomat integrations and i think the reason is, it does not play nice with "convert_to_hash" .. this is a huge issue. |
|
created #152 |
|
@EugenMayer could you provide more detail please? Are you comparing all diplomat integrations for the previous major revision, of do you mean the 2.0.1 release compared with 2.0.0? |
|
Thanks the issue answers my question |
…eAreFarmGeek#120)" This reverts commit e4b8878.
This reverts commit e4b8878 (WeAreFarmGeek#120).
…e value return
Resolves #119