-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: select提供选项定制和回显内容定制 #69
Conversation
if (props.multiple) { | ||
return currentValue.value.includes(option.value); | ||
} | ||
return [currentValue.value].includes(option.value); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
直接用 currentValue.value === option.value ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不改了,差别不大
.map((option) => { | ||
return { | ||
...option, | ||
label: `${option[props.optionLabelField]}`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
如果用户传了 labelField,没有 optionLabelField,这里应该有问题?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
额好像是
components/select/select.vue
Outdated
.map((option) => { | ||
return { | ||
...option, | ||
label: option[props.optionLabelField], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
同理
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
Related issue (if exists):
close #47
Other information: