Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error logs for GitBuddy GitHub API failures #93

Merged
merged 3 commits into from
Oct 24, 2022

Conversation

AvdLee
Copy link
Contributor

@AvdLee AvdLee commented Oct 20, 2022

Instead of:

Exit status of command 'mint run --silent gitbuddy release -l 1.7.5b2622 -b develop --skip-comments --json --use-pre-release --target-commitish build/new-version/1.7.6 --tag-name 1.7.5b2623 --release-title '1.7.5b2623 - Beta'' was 1 instead of 0.
Error: The operation couldn’t be completed. (com.nerdishbynature.octokit error 422.)

We will now get:

Error: GitHub API Request failed (StatusCode: 422): ["RequestKitErrorKey": ["message": Validation Failed, "documentation_url": https://docs.github.com/rest/reference/repos#create-a-release, "errors": <__NSArrayM 0x600001c9a970>(
{
    code = "already_exists";
    field = "tag_name";
    resource = Release;
}
)
]]
Underlying error:
Error Domain=com.nerdishbynature.octokit Code=422 "(null)" UserInfo={RequestKitErrorKey={
    "documentation_url" = "https://docs.github.com/rest/reference/repos#create-a-release";
    errors =     (
                {
            code = "already_exists";
            field = "tag_name";
            resource = Release;
        }
    );
    message = "Validation Failed";
}}

@wetransferplatform
Copy link
Collaborator

Messages
📖

View more details on Bitrise

📖 GitBuddyTests: Executed 57 tests (0 failed, 0 retried, 0 skipped) in 1.134 seconds

Code Coverage Report

Name Coverage
GitBuddy 0.00% ⚠️

Generated by 🚫 Danger Swift against 54cd65b

Copy link
Contributor

@BasThomas BasThomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@AvdLee AvdLee merged commit 9686183 into master Oct 24, 2022
@AvdLee AvdLee deleted the feature/improved-error-logging branch October 24, 2022 07:06
@wetransferplatform
Copy link
Collaborator

Congratulations! 🎉 This was released as part of Release 4.1.4 🚀

Generated by GitBuddy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants