Document that onRequest and completion must be set before calling register() #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcetcheverry
requested review from
AvdLee,
Boris-Em and
kairadiagne
as code owners
Mocker.framework: Coverage: 88.4
Generated by 🚫 Danger Swift against 708e9bd |
AvdLee
approved these changes
Mar 9, 2020
There was a problem hiding this comment.
Thanks, this is from great value! Indeed, making it fail with a fatalError would be a lot better. We should be able to do this by verifying that the mock was registered already but we might run into issues due to the fact that we use a struct.
Feel free to open a contribution for this if you like. However, I'd like to stay with the struct over adding this functionality. So only if we can keep using structs, it's a welcome change!
Boris-Em
approved these changes
Mar 9, 2020
|
Congratulations! 🎉 This was released as part of Release 2.2.0 🚀 Generated by GitBuddy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What may be even better is to throw an assertion if these two variables (and perhaps more), are called after calling
register.Other variables may be affected.
Right now it fails silently for these two.