Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignoring query example swap i/o url #54

Merged
merged 1 commit into from
May 25, 2020

Conversation

GeRryCh
Copy link
Contributor

@GeRryCh GeRryCh commented May 24, 2020

Hi,
I think there's an error in the README.
Thanks.

/// Would transform to "https://www.example.com/api/authentication?oauth_timestamp=151817037" for example.
let originalURL = URL(string: "https://www.example.com/api/authentication")!
/// Would transform to "https://www.example.com/api/authentication" for example.
let originalURL = URL(string: "https://www.example.com/api/authentication?oauth_timestamp=151817037")!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very sharp, indeed! 💪

@ghost
Copy link

ghost commented May 25, 2020

Messages
📖

View more details on Bitrise

📖 Mocker: Executed 18 tests, with 0 failures (0 unexpected) in 1.809 (1.905) seconds

Generated by 🚫 Danger Swift against a8021dc

@AvdLee AvdLee merged commit 4529976 into WeTransfer:master May 25, 2020
@ghost
Copy link

ghost commented May 25, 2020

Congratulations! 🎉 This was released as part of Release 2.2.0 🚀

Generated by GitBuddy

@GeRryCh GeRryCh deleted the correct_readme branch May 25, 2020 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants