Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge release 1.7.0 into master #256

Merged
merged 1 commit into from Jul 23, 2020
Merged

Merge release 1.7.0 into master #256

merged 1 commit into from Jul 23, 2020

Conversation

ghost
Copy link

@ghost ghost commented Jul 22, 2020

Containing all the changes for our 1.7.0 Release.

@ghost ghost requested review from AvdLee and Boris-Em as code owners July 22, 2020 12:12
@ghost
Copy link
Author

ghost commented Jul 22, 2020

Fails
🚫

WeScanTests/CIRectangleDetectorTests.swift#L55 - WeScanTests.CIRectangleDetectorTests: testCorrectlyDetectsAndReturnsQuadilateral
failed - Snapshot comparison failed: Optional(Error Domain=FBSnapshotTestControllerErrorDomain Code=1 "Unable to load reference image." UserInfo={NSLocalizedFailureReason=Reference image not found. You need to run the test in record mode, NSLocalizedDescription=Unable to load reference image., FBReferenceImageFilePathKey=/Users/vagrant/git/WeScanTests/ReferenceImages_64/WeScanTests.CIRectangleDetectorTests/testCorrectlyDetectsAndReturnsQuadilateral_13_6.png})
Warnings
⚠️ Capabilities for Signing & Capabilities may not function correctly because its entitlements use a placeholder team ID. To resolve this, select a development team in the WeScanSampleProject editor. (in target 'WeScanSampleProject' from project 'WeScan')
Messages
📖

View more details on Bitrise
📖 WeScan: Executed 56 tests, with 1 failure (0 unexpected) in 19.412 (19.482) seconds

Generated by 🚫 Danger Swift against 405b480

AvdLee
AvdLee approved these changes Jul 23, 2020
View reviewed changes
Copy link
Contributor

@AvdLee AvdLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Despite seeing that tests fail, the changes in this PR didn't affect this. Merging in!

@AvdLee AvdLee merged commit 7331215 into master Jul 23, 2020
@AvdLee AvdLee deleted the release/1.7.0 branch July 23, 2020 06:26
@wetransferplatform
Copy link
Collaborator

Congratulations! 🎉 This was released as part of Release 1.8.0 🚀

Generated by GitBuddy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Boris-Em Boris-Em Awaiting requested review from Boris-Em

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wetransferplatform @AvdLee