Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #79

Merged
merged 1 commit into from
Nov 14, 2018
Merged

Update README.md #79

merged 1 commit into from
Nov 14, 2018

Conversation

jcampbell05
Copy link
Contributor

Specifies that the project now uses Swift 4.2

@ghost
Copy link

ghost commented Nov 12, 2018

3 Warnings
⚠️ The use of Swift 3 @objc inference in Swift 4 mode is deprecated. Please address deprecated @objc inference warnings, test your code with “Use of deprecated Swift 3 @objc inference” logging enabled, and then disable inference by changing the “Swift 3 @objc Inference” build setting to “Default” for the “FBSnapshotTestCase iOS” target. (in target ‘FBSnapshotTestCase iOS’)
⚠️ VisionRectangleDetectorTests.swift#L44 - WeScanTests/VisionRectangleDetectorTests.swift#L44: constant ‘quad’ inferred to have type ‘()’, which may be unexpected
let quad = VisionRectangleDetector.rectangle(forImage: ciImage) { (quad) in
⚠️ VisionRectangleDetectorTests.swift#L44 - WeScanTests/VisionRectangleDetectorTests.swift#L44: initialization of immutable value ‘quad’ was never used; consider replacing with assignment to ‘_’ or removing it
let quad = VisionRectangleDetector.rectangle(forImage: ciImage) { (quad) in
1 Message
📖 Executed 38 tests, with 0 failures (0 unexpected) in 19.166 (19.324) seconds

Current coverage for WeScan is 38.11%

No files affecting coverage found


Current coverage for WeScanSampleProject is 69.57%

No files affecting coverage found


Powered by xcov

Generated by 🚫 Danger

@julianschiavo
Copy link
Contributor

The Swift 3 error is for FBSnapshotTestCase, not WeScan. Can it be disabled?

@Boris-Em @AvdLee

@Boris-Em Boris-Em requested a review from AvdLee November 13, 2018 09:32
@julianschiavo
Copy link
Contributor

Can we also add a new GIF with the new design?

@Boris-Em
Copy link
Contributor

@justjs, this should be done in a different PR. I created a ticket here to make sure we don't forget about it: #82

@julianschiavo
Copy link
Contributor

👍

@AvdLee AvdLee merged commit 5e6ce63 into WeTransfer:develop Nov 14, 2018
@jcampbell05 jcampbell05 deleted the patch-2 branch November 16, 2018 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants