Hint which parser to apply first using the filename #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julik
changed the title
julik
changed the title
linkyndy
reviewed
Jul 8, 2019
| @@ -1,9 +1,7 @@ | |||
| rvm: | |||
| - 2.2.0 | |||
| - 2.3.0 | |||
| - 2.4.2 | |||
| - 2.5.0 | |||
There was a problem hiding this comment.
I would keeps supporting all Ruby versions that didn't reach their EOL.
There was a problem hiding this comment.
What I wanted to do is to have sufficient "spread" of versions but run less builds. So I've set the lowest supported and the newest supported, assuming that versions in between will kinda work 🕵🏻♂️ Do you think it is safe enough, or would you prefer us test with all minor Ruby versions?
There was a problem hiding this comment.
I would do with all latest minor versions TBH:
- 2.4.6
- 2.5.5
- 2.6.3
- jruby
(I'm not up to date with jruby)
There was a problem hiding this comment.
Okay, let's do that until we bump major
Keep 2.2 because our major version still should be compatible with it - this is a guarantee we give our users
linkyndy
approved these changes
Jul 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some situations we spend way more time applying parsers because the file is in a less-popular format - for example a WAV file. We spend quite a bit of time going through other parsers - some of which are slow. So before we have matched it as a WAV we have to walk through the JPEG parser, then through the ZIP parser (which is quite eager and slow-ish as well), and only at the end we are going to match it as a WAV file.
However, if we know the filename upfront we can do it smarter and apply the parser that is more likely to match first. Note that we won't be assuming the file is of a certain format just based on the filename - we are merely going to rearrange the order of application of the parsers, to optimise it for this particular file.