Fix placeholder missing for implicit else.

WeWatchWall · Apr 1, 2022 · df116e3 · df116e3
1 parent 6f45283
commit df116e3
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 5 deletions.
diff --git a/packages/istanbul-reports/lib/html-spa/assets/sort-arrow-sprite.png b/packages/istanbul-reports/lib/html-spa/assets/sort-arrow-sprite.png
diff --git a/packages/istanbul-reports/lib/html/annotator.js b/packages/istanbul-reports/lib/html/annotator.js
@@ -142,6 +142,20 @@ function annotateBranches(fileCoverage, structuredText) {
         // only highlight if partial branches are missing or if there is a
         // single uncovered branch.
         if (sumCount > 0 || (sumCount === 0 && branchArray.length === 1)) {
+            debugger;
+            // Need to recover the metaArray placeholder item to count an implicit else
+            if (
+                branchMeta[branchName].type === 'if' &&
+                branchArray.length === 2 && 
+                metaArray.length === 1 &&
+                branchArray[1] === 0
+            ) {
+                metaArray[1] = {
+                    "start": {},
+                    "end": {}
+                };
+            }
+
             for (
                 i = 0;
                 i < branchArray.length && i < metaArray.length;

diff --git a/packages/istanbul-reports/lib/html/assets/favicon.png b/packages/istanbul-reports/lib/html/assets/favicon.png
diff --git a/packages/istanbul-reports/lib/html/assets/sort-arrow-sprite.png b/packages/istanbul-reports/lib/html/assets/sort-arrow-sprite.png
diff --git a/packages/istanbul-reports/test/fixtures/github-649.json b/packages/istanbul-reports/test/fixtures/github-649.json
@@ -100,11 +100,6 @@
             "line": 6,
             "column": 5
           }
-        }, {
-          "start": {
-          },
-          "end": {
-          }
         }
       ],
       "line": 4