Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All Range checks are failing and causing the addon to stop functioning with the latest game release: 10.2.52188 #4713

Closed
2 tasks done
voigtboy opened this issue Nov 16, 2023 · 5 comments
Labels
⏱ Awaiting Response This ticket hasn't been triaged yet. 🐛 Bug This is a problem with WeakAuras.

Comments

@voigtboy
Copy link

Is there an existing issue for this?

  • I have searched the existing open and closed issues.

Description

Just noticed this about 10 minutes ago.

WeakAuras Version

5.8.5

World of Warcraft Flavor

Retail (Default)

World of Warcraft Region

US/NA

Tested with only WeakAuras

  • Yes

Lua Error

No response

Reproduction Steps

Create item using the Range action.

Last Good Version

No response

Screenshots

No response

Export String

No response

@voigtboy voigtboy added the 🐛 Bug This is a problem with WeakAuras. label Nov 16, 2023
@github-actions github-actions bot added the ⏱ Awaiting Response This ticket hasn't been triaged yet. label Nov 16, 2023
@Stanzilla
Copy link
Contributor

Yeah Blizzard did that

InfusOnWoW added a commit to InfusOnWoW/WeakAuras2 that referenced this issue Nov 17, 2023
Because Blizzard decided to mess with the range checking in an hotfix.

Fixes: WeakAuras#4713
InfusOnWoW added a commit to InfusOnWoW/WeakAuras2 that referenced this issue Nov 17, 2023
Because Blizzard decided to mess with the range checking in an hotfix.

Fixes: WeakAuras#4713
@Vokilog
Copy link

Vokilog commented Nov 17, 2023

WeakAuras.CheckRange is it based only on items? will it be completely disabled in combat, or redesigned under IsSpellInRange?

@fwater
Copy link

fwater commented Nov 17, 2023

I tested that latest fix([Prototypes.lua. For example, I set a prompt within 20 yards of the Sword of Justice. The distance determined by the plug-in is significantly smaller than the actual distance of skill casting in the game. This distance determination is seriously inaccurate.

@fwater
Copy link

fwater commented Nov 17, 2023

I tested the modified version commented above. Not only is distance detection grossly inaccurate. Some small range distance detection is still invalid. I haven't tested them all, but some distances such as 10, 20, and 30 work. As for the accuracy of distance detection, it should not be as good as the previous version

@Vokilog
Copy link

Vokilog commented Nov 17, 2023

it is clear that the functionality of IsSpellInRange is severely limited by your spells. For someone it will work well, but for someone it's just disgusting.
I'm just considering a way to do at least something, instead of a complete disable.
Use it only whitout combat - idk, it generally has the right to life? I can't think of a good example when a Range Check is needed outside of combat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⏱ Awaiting Response This ticket hasn't been triaged yet. 🐛 Bug This is a problem with WeakAuras.
Projects
None yet
Development

No branches or pull requests

4 participants