Patches #32
Patches #32
Conversation
| @@ -7126,13 +7126,21 @@ function WeakAuras.CreateFrame() | |||
| if not(combinedText == "") then | |||
| combinedText = combinedText.."\n\n"; | |||
| end | |||
| combinedText = combinedText.."--"..childId.."\n"; | |||
|
|
|||
| local formatString | |||
There was a problem hiding this comment.
That looks super weird, should probably be something like
L["-- The following part is the\"%s\" trigger, do not remove this comment"]:format(childId)There was a problem hiding this comment.
It's intentionally... I need the first and second part of the string later to split it up, and I need thos string fragments to be the same between here and there. This makes it so that the translators can't break that.
There was a problem hiding this comment.
I know that this makes the translators job harder, so maybe we should choose a different message... You decide.
There was a problem hiding this comment.
@InfusOnWoW like this then?
L["-- The following part is the \"%s\" trigger, do not remove this comment!"]:format(childId) .. (" $%s$"):format(childId)There was a problem hiding this comment.
Huh, what does that do? Also I'm really not sure whether translators won't mess that up and make the translation below that is used to splice up the text again different from this one.
There was a problem hiding this comment.
Well you need a string to look for when you are matching so we can just add something at the end that you can look for and keep the translation string sane
There was a problem hiding this comment.
Nah, I need to properly split up the string too, to figure out the ids. And I don't want to match random comment lines that are actually part of the aura.
There was a problem hiding this comment.
Well we can make sure that it's something that won't come up usually, something like λ or so
L["-- The following part is the \"%s\" trigger, do not remove this comment!"]:format(childId) .. (" λ%sλ"):format(childId)I'm not 100% sure that this is the right fix, but it seems inline with what the other trigger_options are doing. Ticket-number: 45
Some time ago, I added support for using spellids instead of spell names to the aura trigger. Those spellids were only converted to spellnames in Transmission.lua, and thus on importing a aura. That meant that changing the language wouldn't update the spell names for those spellIds. By moving the code from Transmission.lua to WeakAuras.Add, we always do that and thus fix: Ticket-number: 269
If multiple auras (or a group) is selected, the texteditor combines the text. This patch adds code that splits the code after editing again. Ticket-number: 419
So, this goes back to the very first version I wrote. Full progress should be that the progress angle is equal to end angle. I confussed myself by mainly testing with buff triggers. Those go from full progress to no progress, thus confusingly but correctly they must from full to empty and move in the opposite direction. That is a clockwise buff trigger must move anti-clockwise. So that a resource trigger going from empty to full moves in clokcwise direction. This changes behaviour, but that's better in the long run. Ticket-number: 486
Add options to hide the spark on full or empty progress. Since the spark options are hidden by default this adds very little clutter.
Scaling needs to scale the wedge too. Ticket-number: 503
InfusOnWoW
force-pushed
the
smallpatches
branch
from
9cfa4c4
to
b75c227
Compare
A round of fixes and small improvements for various issues.