Optimization for running trigger function less often #5079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrbuds
force-pushed
the
optimization
branch
4 times, most recently
from
b49b3df
to
9a8dcf3
Compare
mrbuds
added
the
🆕 Feature Preview
|
An experimental build of WeakAuras with the changes in this pull request is available here. |
InfusOnWoW
reviewed
May 18, 2024
InfusOnWoW
reviewed
May 31, 2024
WeakAuras/GenericTrigger.lua
Outdated
| local separatorPosition = composedEvent:find(":", 1, true) | ||
| return separatorPosition == nil and composedEvent or composedEvent:sub(1, separatorPosition - 1) | ||
| end | ||
|
|
||
| ---@param event string | ||
| ---@param arg1? any | ||
| ---@param arg2? any | ||
| ---@param ... any | ||
| function WeakAuras.ScanEvents(event, arg1, arg2, ...) | ||
| local orgEvent = event; |
WeakAuras/Prototypes.lua
Outdated
| @@ -5665,7 +5695,7 @@ Private.event_prototypes = { | |||
| loadFunc = function(trigger) | |||
| trigger.itemName = trigger.itemName or 0; | |||
| local itemName = type(trigger.itemName) == "number" and trigger.itemName or "[["..trigger.itemName.."]]"; | |||
| WeakAuras.WatchItemCooldown(trigger.itemName); | |||
| WeakAuras.WatchItemCooldown(itemName); | |||
There was a problem hiding this comment.
That doesn't look correct, the line above potentially adds "[[" around the name.
…iggers: - Spell Activation Overlay - Cooldown Progress (Spell) - Cooldown Ready (Spell) - Charges Changed - Cooldown Progress (Item) - Cooldown Progress (Equipment Slot) - Cooldown Ready (Item) - Action Usable For Spell triggers, a new loadInternalEventFunc function was added to generate internal_events when aura load instead of when it's added This is meants to make sure the internal event use the same spell name as the loadFunc. Otherwise GetSpellInfo could translate spell to a different one if a talent overload the spell and transform it to a new one
InfusOnWoW
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.