Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Post-release Feedback from Design #47

Merged
merged 1 commit into from
Jul 28, 2020
Merged

Conversation

travis-wb
Copy link
Contributor

Summary

Just small fixes based on post-release feedback from Julian.

QA

  1. in peak-design, yarn link
  2. in peak-design-system, yarn link '@wealthbar/peak-design'
  3. Fire up PDS
  4. On tables page, links in table should shift to a slightly darker colour on mouseover
  5. On modals page, the modal 'card' should have a fade-in / fade-out effect. It still slides, but it should also fade while sliding.

Submitter Checklist:

  • Demo new or changed functionality to stakeholders
  • Perform self-review (see reviewer checklist)
  • Annotate MR with comments for reviewer
  • Document any new patterns or features on peak-design-system
  • Assign a team member who should specifically review this code
  • Address reviewer feedback, if any, and assign back to reviewer

Reviewer Checklist:

  • Version bump in package.json
  • Visually review significant UI changes
  • Assign @pez-wb as reviewer if needed
  • Assign back to submitter with feedback

@travis-wb travis-wb merged commit 8a2d110 into master Jul 28, 2020
@travis-wb travis-wb deleted the fix.tables-and-modals branch July 28, 2020 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants