Merge pull request #13 from WeareJH/hotfix-exception-message

Missing sprintf()
WeareJH · Sep 3, 2014 · 3a7ef18 · 3a7ef18
2 parents 3266331 + 09bea89
commit 3a7ef18
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/src/Jh/DataImportMagento/Writer/OrderStatusWriter.php b/src/Jh/DataImportMagento/Writer/OrderStatusWriter.php
@@ -273,7 +273,9 @@ public function validateItemsToBeShipped(\Mage_Sales_Model_Order $order, array $
         foreach ($items as $item) {
             $orderItem = $order->getItemsCollection()->getItemByColumnValue('sku', $item['sku']);
             if (null === $orderItem) {
-                throw new WriterException('Item with SKU: "%s" does not exist in Order: "%s"', $item['sku']);
+                throw new WriterException(
+                    sprintf('Item with SKU: "%s" does not exist in Order: "%s"', $item['sku'], $order->getIncrementId())
+                );
             }
 
             $return[$orderItem->getId()] = $item['qtyShipped'];

diff --git a/src/Jh/DataImportMagento/Writer/ReturnsWriter.php b/src/Jh/DataImportMagento/Writer/ReturnsWriter.php
@@ -212,7 +212,9 @@ public function validateItemsToBeRefunded(\Mage_Sales_Model_Order $order, array
         foreach ($items as $item) {
             $orderItem = $order->getItemsCollection()->getItemByColumnValue('sku', $item['sku']);
             if (null === $orderItem) {
-                throw new WriterException('Item with SKU: "%s" does not exist in Order: "%s"', $item['sku']);
+                throw new WriterException(
+                    sprintf('Item with SKU: "%s" does not exist in Order: "%s"', $item['sku'], $order->getIncrementId())
+                );
             }
 
             $return[$orderItem->getId()] = $item['qty'];