Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch any exceptions during indexing and add logging for indexers #35

Merged
merged 11 commits into from Jul 17, 2020

Conversation

AydinHassan
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2020

Codecov Report

Merging #35 into master will decrease coverage by 0.18%.
The diff coverage is 72.22%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #35      +/-   ##
============================================
- Coverage     69.63%   69.44%   -0.19%     
- Complexity      538      543       +5     
============================================
  Files            88       88              
  Lines          2170     2186      +16     
============================================
+ Hits           1511     1518       +7     
- Misses          659      668       +9     
Impacted Files Coverage Δ Complexity Δ
src/Progress/CliProgress.php 29.72% <0.00%> (-0.83%) 8.00 <0.00> (ø)
src/Import/Importer.php 85.39% <46.66%> (-8.59%) 25.00 <4.00> (+2.00) ⬇️
src/Import/Indexer.php 87.87% <100.00%> (+3.26%) 11.00 <7.00> (+2.00)
src/Report/Report.php 93.33% <100.00%> (+0.31%) 23.00 <10.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8d1e7d...23cc77a. Read the comment docs.

@AydinHassan AydinHassan merged commit 8d35e0f into master Jul 17, 2020
@AydinHassan AydinHassan deleted the exceptions-and-logging branch July 17, 2020 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants