Marketplace (Commission Search) #180

taedixon · 2016-10-28T23:51:38Z

This set of changes aims to add a commission search feature to Weasyl. This will allow users to find artists who list their current commission status as open, have at least one commission class defined with a price, and match certain search criteria. The new search interface can be found at /marketplace.

Searchers can specify a "type" of commission, which will limit results to those with a commission class that has a name at least partially matching the type provided. In order to encourage usage of standardized classes to make searching more effective for both artists and customers, a list of default commission classes is provided based on the most popular commission class types already existing. This list is also used as an option to populate the name of a commission class when it is being set up. Of course, free-form input for commission classes works on both sides of the equation as well.

This also adds a way to set "preference tags" and "will-not-draw" tags, through /control/editcommissionprices. These tags allow commission searchers to more easily find artists who specialize in types of content they wish to commission, or to filter out artists who are not willing to draw what they want. The search field relating to these tags in /marketplace is labelled "Content"

Searchers can filter results by setting minimum/maximum price values in their preferred currency. Results will be filtered based on prices set on artist's applicable commission classes after being converted to the searcher's currency. In results, values will be displayed in both the currency specified by the artist and the currency specified in the search (if they differ)

Results are ranked on the following criteria:

Number of matching "Preference" tags
Time of most recent submission
The intent of this is to reward artists who are active with submitting to the site with higher rankings in commission searches, which also indicates that the commissioner is more likely to receive a response in a timely manner.

Current known issues:

The UI of the marketplace results page could probably use the touch of someone with a gift for good web design.

Notes:

this change involves a schema upgrade

Conflicts: static/public.css weasyl/commishinfo.py weasyl/controllers/content.py weasyl/controllers/settings.py weasyl/controllers/urls.py

Change ID's #di-tags and #tags-textarea to classes so they can be used more than once per page

Don't include hidden/friends only submissions in example count Expand function comments

codecov-io · 2016-10-28T23:56:45Z

Current coverage is 58.28% (diff: 69.05%)

Merging #180 into master will increase coverage by 0.59%

@@             master       #180   diff @@
==========================================
  Files           151        153     +2   
  Lines         12503      12675   +172   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           7213       7388   +175   
+ Misses         5290       5287     -3   
  Partials          0          0

Powered by Codecov. Last update c894227...94604d5

charmander · 2016-10-29T00:52:07Z

weasyl/commishinfo.py

        "content": content if content else "",
+        "tags": [i["t"] for i in tags_extract if 'n' not in i["s"]],


Are these the only places tags_extract is used? If so, you should be able to write .fetchall() on the query and [i.title for i in tags if 'n' not in i.settings] here, which should be easier to read.

charmander · 2016-10-29T00:55:38Z

weasyl/commishinfo.py

+                GROUP BY sub.userid
+            ) AS example ON example.userid = p.userid
+
+            WHERE p.settings ~ '[os]..?'


I don’t really remember how profile.settings works, but is this equivalent to ^[os]?

it isn't actually because it turns out what I did produced false positives! I'll just uh.. use yours.

charmander · 2016-10-29T00:57:29Z

weasyl/define.py

@@ -598,24 +598,15 @@ def get_path():


 def text_price_amount(target):
-    return "%i.%s%i" % (target / 100, "" if target % 100 > 9 else "0", target % 100)
+    return "%.2f" % round(target / 100, 2)


Doesn’t %.2f already round? Nice one, anyway!

I’m also pretty sure integers are passed into this function at some point, and define.py doesn’t have a from __future__ import division, so you might need to make this target / 100.0.

Fix a bug where counts of tagged submissions didn't match the actual number of matching submissions

kfkitsune · 2016-12-11T01:33:16Z

weasyl/searchtag.py

@@ -167,7 +167,7 @@ def is_tag_restriction_pattern_valid(text):
    return False


-def associate(userid, tags, submitid=None, charid=None, journalid=None):
+def associate(userid, tags, submitid=None, charid=None, journalid=None, artistid=None, optoutid=None):


Could you update the docstring for associate() to include the added artistid and optoutid parameters, please?

kfkitsune · 2016-12-12T00:34:47Z

weasyl/commishinfo.py

@@ -463,6 +463,8 @@ def edit_content(userid, content):

 def remove_class(userid, classid):
    d.execute("DELETE FROM commishclass WHERE (classid, userid) = (%i, %i)", [d.get_int(classid), userid])
+    # poor man's cascade
+    d.execute("DELETE FROM commishprice WHERE (classid, userid) = (%i, %i)", [d.get_int(classid), userid])


Is there any way we can get a proper foreign key relationship added to the Alembic migration script, here (for both onupdate and ondelete cascade)? Also, curious, was it a glitch that there wasn't an FK already established to begin with prior to this PR (to me, it seems like it might have been one)?

Its debatable whether this change belongs in this PR or not to be honest. There was an issue brought up in user acceptance that I couldn't replicate locally so i'd set this to go on testing as a bit of exploratory debugging.
Essentially, if you remove a class without deleting its prices then create a new class, the old prices will be assigned to it. This can also cause other strange behaviour in rendering the commission prices portion of the user profile. So, I'd consider it at least unintended behaviour.
While setting up prices is closely related to marketplace I think the scope of handling this change correctly as well as possibly the numerous other issues that could come up while attempting to modernize commission prices should probably justify shifting the commit into #188

Revert "Remove prices related to a commishclass when that class is removed" This reverts commit 776e219.

Add link to European Bank of Commerce to marketplace help

kfkitsune

Not seeing any issues with this PR at this time. Reviewed up to commit 83bc38f. Based on results on testing, it seems to do what the tin says it should be doing.

This might help emphasize a bit that it’s not a filter. Not really optimal, though.

charmander · 2016-12-21T04:36:09Z

Some changes suggested in taedixon#1.

merge in charmander's marketplace design changes

charmander · 2016-12-24T05:41:46Z

templates/etc/marketplace.html

+            </div>
+          $# commission description
+          <div class="formatted-content marketplace-desc-preview">
+            $if artist.get('description'):


Will the 'description' key ever not exist?

If the user sets up their commission prices but does not fill out the "Additional Information" field, the value may be None. If they fill it out then erase it at a later date, it may be an empty string. But in either case, I can't see a situation where the key itself will be missing under the current setup.

charmander · 2016-12-24T05:42:42Z

templates/help/help.html

@@ -17,6 +17,7 @@
 				<li><a href="/help/ratings">Content Ratings</a></li>
 				<li><a href="/help/google-drive-embed">Google Drive Embedding</a></li>
 				<li><a href="/help/searching">Searching on Weasyl</a></li>
+        <li><a href="/help/marketplace">Using the Marketplace</a></li>


This file appears to use tab indentation; may as well follow that for now.

charmander · 2016-12-24T05:45:50Z

templates/help/marketplace.html

+
+    <h3>What is the Marketplace?</h3>
+    <div class="formatted-content">
+      <p>The Marketplace is Weasyl’s Commission Search tool. You can use it to find artists who are open for commissions that match your search criteria.</p>


Why is “Commission Search” capitalized?

charmander · 2016-12-24T05:46:31Z

templates/help/marketplace.html

+      <p>Marketplace currently supports the following search criteria:</p>
+
+      <ul>
+        <li>Type of Commission (e.g. badge)</li>


“Commission” probably shouldn’t be capitalized here to match “range and currency” below.

Capitalization changes to help pages

Use number input type for currency fields

hyena

I love this. I want charmander to sign off first, though.

If necessary, cut the conversions. It's not really our job anyway.....

hyena · 2016-12-28T21:16:14Z

etc/SETTINGS.txt

@@ -100,6 +101,9 @@ y  Japanese yen
 c  Canadian dollar
 m  Mexican peso
 u  Australian dollar
+z  New Zealand dollar


hyena · 2016-12-28T21:19:17Z

templates/etc/marketplace.html

+            $if artist['pricemin']:
+              $# display low end of price range in artist's currency
+              <span>$:{'from ' if artist['pricemax'] else ''}${SYMBOL(artist['pricesettings'])} ${PRICE(artist['pricemin'])}</span>
+              $if artist['pricemax'] and artist['pricemax'] != artist['pricemin']:


Thanks for making ranges optional.

hyena · 2016-12-28T21:20:50Z

templates/help/marketplace.html

+
+    <h3>Price</h3>
+    <div class="formatted-content">
+      <p>Marketplace searches can have a minimum and/or maximum price, and you can specify your preferred currency.</p>


Nit: and optionally maximum price.

hyena · 2016-12-28T21:21:37Z

templates/etc/marketplace.html

+              $if artist['pricesettings'] != form.currency and artist['localmin']:
+                $if artist['localmax'] and artist['localmax'] != artist['localmin']:
+                  $# display converted prices (range)
+                  (<span>Approx. ${SYMBOL(form.currency)} ${PRICE(artist['localmin'])}</span>


Thanks for showing this separately.

hyena · 2016-12-29T05:31:39Z

Ranges are nice. But what most people are going to want to do is provide add-ons. (e.g. 'additional characters at $5 each'). How do you see people representing that in this implementation?

taedixon and others added 20 commits May 29, 2016 17:27

Build initial proof-of-concept for Artist Marketplace

ae41923

Convert artist currency to searcher's currency

cbf73b1

Allow artists to assign tags to themselves

6df3a6a

Support 10 most traded currencies

eee89a5

Filter search results by Commission Class

69a29e8

Prioritize search results by content preferences

34f5d3c

Centralize location of currency information

26036ab

Document and cleanup commishinfo.py

db393d6

Relocate inline CSS

717db82

Remember selected commishclass presets in search

1a83d46

Merge branch 'master' into g-marketplace-prototype

67808a6

Conflicts: static/public.css weasyl/commishinfo.py weasyl/controllers/content.py weasyl/controllers/settings.py weasyl/controllers/urls.py

Add missing tables and CSS from merge

94c0fce

Allow multiple tag forms on same page

d6bafec

Change ID's #di-tags and #tags-textarea to classes so they can be used more than once per page

Add the ability to define no-draw tags

cfb92cd

Filter artists with no-draw tags from marketplace search results

c457d98

Fixes rounding bug in price formatter

c0317eb

Add links to examples of work in marketplace results

2f00b96

Add result pagination

0a089fb

Apply min/max prices in terms of the searcher's currency

9a8cec1

Remove ignored/suspended users from results

715ed19

Don't include hidden/friends only submissions in example count Expand function comments

taedixon added enhancement help wanted DO NOT MERGE YET labels Oct 28, 2016

Merge branch 'master' into g-marketplace-prototype

dba223b

charmander reviewed Oct 29, 2016

View reviewed changes

charmander modified the milestone: Pre-cleanup Oct 29, 2016

Hendikins mentioned this pull request Dec 8, 2016

Overhaul Commission Information Management #188

Open

taedixon added 3 commits December 8, 2016 16:06

Return None from currency conversion in event of failure

48ec0cf

Add marketplace help page

3275f10

Fix a bug where counts of tagged submissions didn't match the actual number of matching submissions

Remove prices related to a commishclass when that class is removed

776e219

kfkitsune requested changes Dec 12, 2016

View reviewed changes

taedixon added 3 commits December 16, 2016 03:11

Cutoff marketplace result descriptions

f451a16

Revert "Remove prices related to a commishclass when that class is removed" This reverts commit 776e219.

Remove references to commishprice help pages

602be42

Update searchtag.associate docstring

e138668

Add link to European Bank of Commerce to marketplace help

taedixon removed the DO NOT MERGE YET label Dec 17, 2016

Fix missing addon prices

83bc38f

kfkitsune approved these changes Dec 21, 2016

View reviewed changes

charmander added 7 commits December 20, 2016 20:10

Use namedtuples for currencies

fa4f93a

Store currency symbols as normal text

b9a4035

Only show free input field when Other option is selected

281235f

Group commission type presets

fc2322c

Place minimum and maximum price filters side-by-side

9c655ca

Remove double-labelling

6f28efd

Relabel “Currency” to “Display Currency”

c22fb34

This might help emphasize a bit that it’s not a filter. Not really optimal, though.

Merge pull request #1 from charmander/some-marketplace-design

597ac06

merge in charmander's marketplace design changes

charmander requested changes Dec 24, 2016

View reviewed changes

taedixon added 2 commits December 24, 2016 14:53

Give preset commishclass priority over custom in marketplace search

b1b2042

Capitalization changes to help pages

Used namedtuple attributes in editcommissionprices

cc58733

Use number input type for currency fields

hyena approved these changes Dec 28, 2016

View reviewed changes

taedixon force-pushed the g-marketplace-prototype branch from f139d94 to 504e0cb Compare December 30, 2016 01:44

Update marketplace help screenshots

94604d5

taedixon force-pushed the g-marketplace-prototype branch from 504e0cb to 94604d5 Compare December 30, 2016 01:56

skylerbunny merged commit 2269a43 into Weasyl:master Dec 30, 2016

skylerbunny mentioned this pull request Dec 31, 2016

Revert "Marketplace (Commission Search)" #190

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Marketplace (Commission Search) #180

Marketplace (Commission Search) #180

taedixon commented Oct 28, 2016 •

edited

codecov-io commented Oct 28, 2016 •

edited

charmander Oct 29, 2016

charmander Oct 29, 2016

taedixon Oct 31, 2016

charmander Oct 29, 2016

charmander Oct 31, 2016

kfkitsune Dec 11, 2016

kfkitsune Dec 12, 2016

taedixon Dec 12, 2016

kfkitsune left a comment

charmander commented Dec 21, 2016

charmander Dec 24, 2016

taedixon Dec 24, 2016

charmander Dec 24, 2016

charmander Dec 24, 2016

charmander Dec 24, 2016

hyena left a comment

hyena Dec 28, 2016

hyena Dec 28, 2016

hyena Dec 28, 2016

hyena Dec 28, 2016

hyena commented Dec 29, 2016

		"content": content if content else "",
		"tags": [i["t"] for i in tags_extract if 'n' not in i["s"]],

Marketplace (Commission Search) #180

Marketplace (Commission Search) #180

Conversation

taedixon commented Oct 28, 2016 • edited

codecov-io commented Oct 28, 2016 • edited

Current coverage is 58.28% (diff: 69.05%)

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kfkitsune left a comment

Choose a reason for hiding this comment

charmander commented Dec 21, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hyena left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hyena commented Dec 29, 2016

taedixon commented Oct 28, 2016 •

edited

codecov-io commented Oct 28, 2016 •

edited