Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comments to site updates #465

Merged
merged 3 commits into from Feb 15, 2019

Conversation

charmander
Copy link
Contributor

This is not very nice. Sorry.

#415

@codecov-io
Copy link

codecov-io commented Jan 22, 2019

Codecov Report

Merging #465 into master will decrease coverage by 0.03%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #465      +/-   ##
==========================================
- Coverage    64.2%   64.16%   -0.04%     
==========================================
  Files         158      158              
  Lines       13498    13552      +54     
==========================================
+ Hits         8666     8696      +30     
- Misses       4832     4856      +24
Impacted Files Coverage Δ
weasyl/test/web/test_site_updates.py 100% <ø> (ø) ⬆️
weasyl/siteupdate.py 100% <ø> (ø) ⬆️
weasyl/controllers/content.py 32.16% <0%> (-0.48%) ⬇️
libweasyl/libweasyl/models/tables.py 100% <100%> (ø) ⬆️
weasyl/controllers/general.py 51.92% <100%> (+1.92%) ⬆️
weasyl/message.py 56.41% <100%> (+1.14%) ⬆️
weasyl/welcome.py 74.21% <66.66%> (-0.96%) ⬇️
weasyl/comment.py 75.32% <69.35%> (-5.51%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61dda2b...3b4e951. Read the comment docs.

This is not very nice. Sorry.
Copy link
Member

@kfkitsune kfkitsune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, nginx is still doing a redirect loop. I noticed we're using 1.10.3 whereas the current version per nginx's main site is 1.15.8; I previously did capture a redirect loop here: https://paste.weasyldev.com/show/C0rSV13ewkA57yvGpome/

Unfortunately, I really can't test this given the development environment is current;y still erroring when I am, attempting to visit /site-updates. As far as what is in the MR, it looks like it should work. A vagrant provision, followed by trying to bring the site up worked, but the site updates is borked.

Copy link
Member

@kfkitsune kfkitsune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, so after killing the line at https://github.com/Weasyl/weasyl/blob/master/Vagrantfile#L82 (rewrite ^/(.*)/$ /\\$1 permanent;), that fixes the nginx redirect issue.

Now that it functions, it appears as if this one does what it says on the tin. Comments can now be added to site updates.

@kfkitsune
Copy link
Member

Okay, so after killing the line at https://github.com/Weasyl/weasyl/blob/master/Vagrantfile#L82 (rewrite ^/(.*)/$ /\\$1 permanent;), that fixes the nginx redirect issue.

Now that it functions, it appears as if this one does what it says on the tin. Comments can now be added to site updates.

Follow-up from Gitter, but removing that line now makes /~wesley/ 404 versus a "user doesn't exist", as /~wesley does.

@charmander charmander merged commit c6455b4 into Weasyl:master Feb 15, 2019
@charmander charmander deleted the site-update-comments branch February 15, 2019 04:33
sl1-1 pushed a commit to sl1-1/weasyl that referenced this pull request Jan 5, 2020
This is not very nice. Sorry.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants