New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add comments to site updates #465
Conversation
9721f5e
to
0396efe
Compare
Codecov Report
@@ Coverage Diff @@
## master #465 +/- ##
==========================================
- Coverage 64.2% 64.16% -0.04%
==========================================
Files 158 158
Lines 13498 13552 +54
==========================================
+ Hits 8666 8696 +30
- Misses 4832 4856 +24
Continue to review full report at Codecov.
|
This is not very nice. Sorry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, nginx is still doing a redirect loop. I noticed we're using 1.10.3
whereas the current version per nginx's main site is 1.15.8
; I previously did capture a redirect loop here: https://paste.weasyldev.com/show/C0rSV13ewkA57yvGpome/
Unfortunately, I really can't test this given the development environment is current;y still erroring when I am, attempting to visit /site-updates
. As far as what is in the MR, it looks like it should work. A vagrant provision
, followed by trying to bring the site up worked, but the site updates is borked.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, so after killing the line at https://github.com/Weasyl/weasyl/blob/master/Vagrantfile#L82 (rewrite ^/(.*)/$ /\\$1 permanent;
), that fixes the nginx redirect issue.
Now that it functions, it appears as if this one does what it says on the tin. Comments can now be added to site updates.
Follow-up from Gitter, but removing that line now makes |
This is not very nice. Sorry.
This is not very nice. Sorry.
#415