Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CollectionHeader section #11

Merged
merged 7 commits into from
Sep 29, 2023
Merged

Add CollectionHeader section #11

merged 7 commits into from
Sep 29, 2023

Conversation

dangthang1903
Copy link
Contributor

No description provided.

@hta218 hta218 self-requested a review September 26, 2023 04:53
@hta218 hta218 changed the title create-section-collectionHeader Add CollectionHeader section Sep 26, 2023
hta218
hta218 reviewed Sep 26, 2023
View reviewed changes
package-lock.json Outdated Show resolved Hide resolved
hta218
hta218 reviewed Sep 26, 2023
View reviewed changes
app/weaverse/components.ts Outdated Show resolved Hide resolved
hta218
hta218 requested changes Sep 26, 2023
View reviewed changes
app/weaverse/components.ts Outdated Show resolved Hide resolved
package-lock.json Outdated Show resolved Hide resolved
app/sections/collection-header.tsx Show resolved Hide resolved
hta218
hta218 requested changes Sep 28, 2023
View reviewed changes
Copy link
Member

@hta218 hta218 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update your section.
Btw please install this extension on your VScode: EditorConfig for VS Code to have the same coding style across our team

app/sections/collection-header.tsx Outdated Show resolved Hide resolved
app/sections/collection-header.tsx Outdated Show resolved Hide resolved
app/sections/collection-header.tsx Outdated Show resolved Hide resolved
app/sections/collection-header.tsx Outdated Show resolved Hide resolved
app/sections/collection-header.tsx Outdated Show resolved Hide resolved
app/sections/collection-header.tsx Outdated Show resolved Hide resolved
app/sections/collection-header.tsx Outdated Show resolved Hide resolved
app/sections/collection-header.tsx Outdated Show resolved Hide resolved
app/sections/collection-header.tsx Outdated Show resolved Hide resolved
hta218
hta218 approved these changes Sep 29, 2023
View reviewed changes
Copy link
Member

@hta218 hta218 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on landing your first PR merge. Keep up the good work bro. 👏

@hta218 hta218 merged commit 9836391 into main Sep 29, 2023
@hta218 hta218 deleted the build-collection-header-section branch October 10, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hta218 hta218 hta218 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dangthang1903 @hta218