Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when compiling my project using your 2.1.0 component version #4

Open
matteo-mosca opened this issue Aug 29, 2018 · 5 comments
Open

Comments

@matteo-mosca
Copy link

Hi, I just updated my dependency to your component and running an ng build --aot I get this error on your component:

ERROR in node_modules/@webacad/ng-mat-file-upload/mat-file-upload.component.d.ts(13,62): error TS1005: ',' expected.
node_modules/@webacad/ng-mat-file-upload/mat-file-upload.component.d.ts(13,159): error TS1005: '(' expected.
node_modules/@webacad/ng-mat-file-upload/mat-file-upload.component.d.ts(13,194): error TS1005: ')' expected.

Thanks.

@davidkudera
Copy link
Member

Hi, which version of angular and typescript are you using?

@matteo-mosca
Copy link
Author

matteo-mosca commented Aug 29, 2018 via email

@davidkudera
Copy link
Member

Hmm.. Thats strange, I updated this package few days ago for angular 6. Versions < 2.1.0 was for Angular 5.

Also I'm using it with typescript 2.9.2 and angular 6.1.1 and everything works just fine.

Could you please create some small project eg. on stackblitz.com?

@matteo-mosca
Copy link
Author

Sorry for the late answer but I've been busy on other things. I can show you the problem with a simple screenshot. When opening the file mat-file-upload.component.d.ts with VS from the imported library through npm we can clearly see the errors (I've covered my project name for privacy):

image

There you can see all the errors found. The same errors are reported by the angular cli command line compiler.

@vladut91
Copy link

vladut91 commented Oct 23, 2018

I also have the same issue.
Create a new project from scratch with cli, added material latest version

"dependencies": {
"@angular/animations": "^5.2.11",
"@angular/cdk": "^7.0.1",
"@angular/common": "^5.2.0",
"@angular/compiler": "^5.2.0",
"@angular/core": "^5.2.0",
"@angular/forms": "^5.2.0",
"@angular/http": "^5.2.0",
"@angular/material": "^7.0.1",
"@angular/platform-browser": "^5.2.0",
"@angular/platform-browser-dynamic": "^5.2.0",
"@angular/router": "^5.2.0",
"@webacad/ng-mat-file-upload": "^2.1.0",
"@webacad/observable-file-reader": "^0.2.0",
"core-js": "^2.4.1",
"hammerjs": "^2.0.8",
"rxjs": "^5.5.12",
"zone.js": "^0.8.19"
},
"devDependencies": {
"@angular/cli": "1.6.7",
"@angular/compiler-cli": "^5.2.0",
"@angular/language-service": "^5.2.0",
"@types/jasmine": "~2.8.3",
"@types/jasminewd2": "~2.0.2",
"@types/node": "~6.0.60",
"codelyzer": "^4.0.1",
"jasmine-core": "~2.8.0",
"jasmine-spec-reporter": "~4.2.1",
"karma": "~2.0.0",
"karma-chrome-launcher": "~2.2.0",
"karma-coverage-istanbul-reporter": "^1.2.1",
"karma-jasmine": "~1.1.0",
"karma-jasmine-html-reporter": "^0.2.2",
"protractor": "~5.1.2",
"ts-node": "~4.1.0",
"tslint": "~5.9.1",
"typescript": "~2.5.3"
}

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants