Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/nomodal-events #1824

Merged
merged 5 commits into from
May 9, 2024
Merged

Conversation

chaitanyapotti
Copy link
Member

@chaitanyapotti chaitanyapotti commented May 8, 2024

Fixes #1804


name: Feature PR
about: Adding a ready event
title: "Add Ready event when nomodal or modal sdk are ready"
labels: ""
assignees: ""

Description

NoModal and Modal SDKs now emit ADAPTER_EVENTS.READY when they are done initializing

Type of change

  • New feature (non-breaking change which adds functionality)
  • Breaking change (feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Tested using demo app

Copy link
Contributor

@arch1995 arch1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chaitanyapotti chaitanyapotti merged commit aa2a206 into feat/hooks-refactor May 9, 2024
2 checks passed
@chaitanyapotti chaitanyapotti deleted the feat/nomodal-events branch May 9, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants