Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added firefox add-on link to readme and to popup.html #20

Merged
merged 3 commits into from
Jul 7, 2023
Merged

added firefox add-on link to readme and to popup.html #20

merged 3 commits into from
Jul 7, 2023

Conversation

karenhernandeze
Copy link
Contributor

I added the firefox add-on to the table in the Readme and based upon suggestions made by @warengonzaga of also adding these links to the popoup.html file, those changes were also made.

@karenhernandeze
Copy link
Contributor Author

Resulting in the following:

Screenshot 2023-07-06 at 11 09 07 a m

@warengonzaga warengonzaga self-requested a review July 7, 2023 01:11
@warengonzaga warengonzaga added docs Project Documentation (Issue/PR) tweak Enhancements (Issue/PR) under review Under Review Status (Issue/PR) labels Jul 7, 2023
Co-Authored-By: Karen Alicia <49078535+karenhernandeze@users.noreply.github.com>
@warengonzaga
Copy link
Member

Resulting in the following:

Screenshot 2023-07-06 at 11 09 07 a m

Thank you for your effort in bringing this to a pop-up HTML file. However, we can make it even more smaller and make it as an icon only. I'll modify your code.

Co-Authored-By: Karen Alicia <49078535+karenhernandeze@users.noreply.github.com>
Copy link
Member

@warengonzaga warengonzaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @karenhernandeze for your contribution.

@warengonzaga
Copy link
Member

Here's the updated UI @karenhernandeze
image

@warengonzaga warengonzaga merged commit 46fb658 into Web3Philippines:dev Jul 7, 2023
@warengonzaga warengonzaga linked an issue Jul 7, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Project Documentation (Issue/PR) tweak Enhancements (Issue/PR) under review Under Review Status (Issue/PR)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add firefox add-on link to readme
2 participants