Remove the cputime clocks. #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterhuene
approved these changes
Jan 12, 2020
|
Please merge with |
Remove $process_cputime_id and $thread_cputime_id. Some implementations will not have one wasm nanoprocess per OS process, or one wasm thread per OS thread, making it difficult to implement $process_cputime_id meaningfully. Also, the concept of "cputime" available in most host environments isn't easy to directly connect to what we might expect "cputime" to mean for wasm code. These correspond to `CLOCK_PROCESS_CPUTIME_ID` and `CLOCK_THREAD_CPUTIME_ID` in POSIX, which are optional: https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/time.h.html
sunfishcode
force-pushed
the
no-cputime
branch
from
6a5a908
to
7e26382
Compare
|
Merged with master and docs auto-generated. |
9 tasks
sunfishcode
added a commit
to sunfishcode/wasi-test
that referenced
this pull request
Feb 11, 2021
Remove the tests for `CLOCKID_PROCESS_CPUTIME_ID` and `CLOCKID_THREAD_CPUTIME_ID`, since these values were [removed from the WASI spec]. [removed from the WASI spec]: WebAssembly/WASI#197
caspervonb
pushed a commit
to khronosproject/wasi-test
that referenced
this pull request
Feb 11, 2021
Remove the tests for `CLOCKID_PROCESS_CPUTIME_ID` and `CLOCKID_THREAD_CPUTIME_ID`, since these values were [removed from the WASI spec]. [removed from the WASI spec]: WebAssembly/WASI#197
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove $process_cputime_id and $thread_cputime_id.
Some implementations will not have one wasm nanoprocess per OS process,
or one wasm thread per OS thread, making it difficult to implement
$process_cputime_id meaningfully. Also, the concept of "cputime"
available in most host environments isn't easy to directly connect to
what we might expect "cputime" to mean for wasm code.
These correspond to
CLOCK_PROCESS_CPUTIME_IDandCLOCK_THREAD_CPUTIME_IDin POSIX, which are optional:
https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/time.h.html