Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elaborate on the definitions of commands and reactors. #282

Merged
merged 2 commits into from
May 29, 2020

Conversation

sunfishcode
Copy link
Member

This pulls out the parts of #281 which document existing practice.

This pulls out the parts of WebAssembly#281 which document existing practice.
Copy link
Member

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm % comments

design/application-abi.md Show resolved Hide resolved
design/application-abi.md Show resolved Hide resolved
For compatibility with existing toolchains, modules may also export globals
named `__heap_base` and `__data_end`. Environments shall not access them.
This provision is deprecated and toolchains are encouraged to avoid providing
these exports.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this paragraph still needed, given that it seems we are (currently) allowing arbitrary additional exports in all cases anyway?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed; I've now simplified this text.

We no longer need to say "applications may export these", but it's still
useful to say that environments shouldn't access them.
@sunfishcode sunfishcode merged commit 9a1cb4d into WebAssembly:master May 29, 2020
@sunfishcode sunfishcode deleted the clarify-commands branch May 29, 2020 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants