witx: Add trait implementations to Id
#287
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on bytecodealliance/wasmtime#1793, I noticed that
Id
cannot be compared against strings, or referenced as a string slice. Whileas_str
can be used, this often means hanging onto a temporary value, i.e.let id_str: &str = id.as_str()
.Because
Id
is a newtype wrapper around a singleString
, it felt like these would be both useful & safe to expose a few more trait implementations, delegating to the underlyingString
value.After applying these changes, this code will compile: