witx: remove supertypes from the handle type #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the idea here was to enable handles to have a subtyping hierarchy, but this isnt compatible with wasm extern refs and we never used it anywhere, so its safe to delete all this code.
alexcrichton
approved these changes
Nov 30, 2020
|
The subtype relationships are meant to anticipate subtyping in type imports. Type imports are better than externref for WASI because externrefs aren't virtualizable, since they can only be created by the host, so it'd be good to keep the subtype relationships in anticipation of using them with type imports. |
|
oh! as usual I got it backwards. I think i'd like to keep this code out for YAGNI reasons. If we need to add it back in, its not too difficult to do so, either by revert or manually. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the idea here was to enable handles to have a subtyping hierarchy,
but this isnt compatible with wasm extern refs and we never used it
anywhere, so its safe to delete all this code.
See also #357