Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

witx: remove supertypes from the handle type #358

Merged
merged 1 commit into from
Nov 30, 2020

Conversation

pchickey
Copy link
Contributor

the idea here was to enable handles to have a subtyping hierarchy,
but this isnt compatible with wasm extern refs and we never used it
anywhere, so its safe to delete all this code.

See also #357

the idea here was to enable handles to have a subtyping hierarchy,
but this isnt compatible with wasm extern refs and we never used it
anywhere, so its safe to delete all this code.
@pchickey pchickey merged commit fa7c8f5 into master Nov 30, 2020
@pchickey pchickey deleted the pch/remove_handle_supertypes branch November 30, 2020 19:09
@sunfishcode
Copy link
Member

The subtype relationships are meant to anticipate subtyping in type imports.

Type imports are better than externref for WASI because externrefs aren't virtualizable, since they can only be created by the host, so it'd be good to keep the subtype relationships in anticipation of using them with type imports.

@pchickey
Copy link
Contributor Author

oh! as usual I got it backwards. I think i'd like to keep this code out for YAGNI reasons. If we need to add it back in, its not too difficult to do so, either by revert or manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants