Add the (@witx noreturn) annotation to proc_exit
#371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The noreturn annotation was invented solely for the sake of proc_exit, but we never actually used it in the spec documents. This annotation sets the `noreturn` bit in the `InterfaceFunc` struct. Downstream tools are free to do with that bit what they will.
sbc100
approved these changes
Jan 6, 2021
|
LGTM too; looks like the CI just wants a few test cleanups as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The noreturn annotation was invented solely for the sake of proc_exit,
but we never actually used it in the spec documents.
This annotation sets the
noreturnbit in theInterfaceFuncstruct.Downstream tools are free to do with that bit what they will.