Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused variable warning when building with g++-7 #4353

Closed
sbc100 opened this issue Nov 22, 2021 · 0 comments
Closed

Unused variable warning when building with g++-7 #4353

sbc100 opened this issue Nov 22, 2021 · 0 comments

Comments

@sbc100
Copy link
Member

sbc100 commented Nov 22, 2021

We build binaryen with g++-7 as part of emsdk CI and we are getting unused variable warning regarding:

for (auto& [func, info] : analysis.map) {
for (auto* set : info.sets) {
lubs[set->name].noteUpdatableExpression(set->value);
}
}

See https://app.circleci.com/pipelines/github/emscripten-core/emsdk/1385/workflows/d696706d-f612-429d-94ae-12b0742e7cfb/jobs/7067?invite=true#step-105-303

This seems to not effect g++-8 and above or clang++ or mscv I guess (otherwise binaryen CI would have failed).

Its not clear we want to continue to support g++-7 but filing this issue so I can reference it in my emsdk change.

Related PR: #3104

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant