Set an absolute maximum inlining limit #3959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
aheejin
reviewed
Jun 29, 2021
| auto combinedSize = infos[target].size + infos[source].size; | ||
| // Estimate the binary size from the number of instructions. | ||
| auto estimatedBinarySize = Measurer::BytesPerExpr * combinedSize; | ||
| const Index MaxCombinedBinarySize = 400 * 1024; |
There was a problem hiding this comment.
Is this an arbitrary limit? Maybe good to add a single-line comment on what this is. If this is an arbitrary limit, stating that will help readers too, in case they think this number has a specific meaning.
aheejin
approved these changes
Jun 29, 2021
aheejin
reviewed
Jun 29, 2021
src/passes/Inlining.cpp
Outdated
| @@ -446,6 +449,20 @@ struct Inlining : public Pass { | |||
| // return whether we did any work | |||
| return inlinedUses.size() > 0; | |||
| } | |||
|
|
|||
| // Checks if we are allowed to inline source into target. | |||
| bool canInlineInto(Name target, Name source) { | |||
There was a problem hiding this comment.
Nit: How about isProfitableToInline or something..? It is not that technically we cannot inline but we choose not to because of performance reasons..
There was a problem hiding this comment.
Maybe isUnderSizeLimit to be precise?
|
Thanks for the feedback, done. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have seen some cases in both Chrome and Firefox where
extremely large modules cause overhead,
#3730 (comment) (and link therein)
emscripten-core/emscripten#13899 (comment)
There is no "right" value to use as a limit here, but pick an
arbitrary one that is very high. (This setting is verified to have
no effect on the emscripten benchmark suite.)