Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add binary format parse checking for ref.as input type #4389

Merged
merged 1 commit into from Dec 16, 2021
Merged

Add binary format parse checking for ref.as input type #4389

merged 1 commit into from Dec 16, 2021

Conversation

kripken
Copy link
Member

@kripken kripken commented Dec 14, 2021 •
edited

If that type is not valid then we cannot even create and finalize the node,
which means we'd hit an assertion inside finalize(), before we reach the
validator.

Fixes #4383

@kripken kripken merged commit 62d83d5 into main Dec 16, 2021
@kripken kripken deleted the fix-4383 branch December 16, 2021 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlively tlively tlively approved these changes

@aheejin aheejin Awaiting requested review from aheejin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

An assertion abort in wasm::handle_unreachable(char const*, char const*, unsigned int) ()
2 participants
@kripken @tlively