Fix merge-similar-functions test expections #4534
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests in #4414 have different results than expected when I run
the auto updater script on them. In this PR is what I get locally when
I run that script.
This seems wrong, as when running the test manually - for example,
running
-all -merge-similar-functions
on the first module intest/lit/passes/merge-similar-functions.wast
- then I do see thefunction in the output. The function has to be there, in fact, as it
is called by others after the pass runs, so it would not validate without
it. However, for some reason the auto update script removes it.
@tlively any idea?