Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Outlining] Add variations of call_indirect tests #6152

Merged

Conversation

ashleynh
Copy link
Collaborator

@ashleynh ashleynh commented Dec 7, 2023

Mixes up the number of results, params, and operands used in
call_indirect instructions that are outlined. Also adds a function
identifier to the original call_indirect test to improve test output
readability.

@ashleynh ashleynh requested a review from tlively December 7, 2023 06:21
)

;; Test outlining works with call_indirect
;; 2 results, 0 params, 1 operand
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No longer 2 results!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, thanks!

@ashleynh ashleynh changed the base branch from spr/ashleynh-main.outlining-add-variations-of-call_indirect-tests to main December 7, 2023 10:16
Created using spr 1.3.4
Created using spr 1.3.4
Created using spr 1.3.4
@ashleynh ashleynh merged commit f2eea9d into main Dec 7, 2023
14 checks passed
@ashleynh ashleynh deleted the spr/ashleynh-outlining-add-variations-of-call_indirect-tests branch December 7, 2023 10:47
radekdoulik pushed a commit to dotnet/binaryen that referenced this pull request Jul 12, 2024
Mixes up the number of results, params, and operands used in
call_indirect instructions that are outlined. Also adds a function
identifier to the original call_indirect test to improve test output
readability.

Reviewers: tlively

Reviewed By: tlively

Pull Request: WebAssembly#6152
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants