Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Parser] Parse the remaining array operations #6158

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Conversation

tlively
Copy link
Member

@tlively tlively commented Dec 8, 2023

Parse array.new_elem, array.init_data, and array.init_elem.

@tlively
Copy link
Member Author

tlively commented Dec 8, 2023

@tlively
Copy link
Member Author

tlively commented Dec 12, 2023

Oops, I forgot the stringref PR was based on this one and merged it, so now this has code from both PRs. Ignore the stringref commit when reviewing this.

@tlively tlively requested a review from kripken December 12, 2023 22:02
Base automatically changed from parser-rethrow to main December 13, 2023 02:50
@tlively tlively merged commit 9e63685 into main Dec 13, 2023
27 checks passed
@tlively tlively deleted the parser-array-segment-ops branch December 13, 2023 04:28
radekdoulik pushed a commit to dotnet/binaryen that referenced this pull request Jul 12, 2024
Parse `array.new_elem`, `array.init_data`, and `array.init_elem`.

Accidentally also includes:

* [Parser] Parse string types and operations (WebAssembly#6161)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants