Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EH] Use random value for exnref encoding when legacy GC is used #6166

Merged
merged 5 commits into from
Dec 12, 2023

Conversation

aheejin
Copy link
Member

@aheejin aheejin commented Dec 11, 2023

Currently the legacy GC encoding's nullexternref encoding overlaps with exnref's. We assume the legacy GC encoding won't be used with the exnref for the moment and assign a random value to it to prevent the clash.

Currently the legacy GC encoding's nullexternref encoding overlaps with
exnref's. We assume the legacy GC encoding won't be used with the exnref
for the moment and assign a random value to it to prevent the clash.
@aheejin
Copy link
Member Author

aheejin commented Dec 11, 2023

alpine CI fails with:

Run ./alpine.sh pip3 install -r requirements-dev.txt
error: externally-managed-environment

× This environment is externally managed
╰─> 
    The system-wide python installation should be maintained using the system
    package manager (apk) only.
    
    If the package in question is not packaged already (and hence installable via
    "apk add py3-somepackage"), please consider installing it inside a virtual
    environment, e.g.:
    
    python3 -m venv /path/to/venv
    . /path/to/venv/bin/activate
    pip install mypackage
    
    To exit the virtual environment, run:
    
    deactivate
    
    The virtual environment is not deleted, and can be re-entered by re-sourcing
    the activate file.
    
    To automatically manage virtual environments, consider using pipx (from the
    pipx package).

note: If you believe this is a mistake, please contact your Python installation or OS distribution provider. You can override this, at the risk of breaking your Python installation or OS, by passing --break-system-packages.
hint: See PEP [6](https://github.com/WebAssembly/binaryen/actions/runs/7174694536/job/19536698686?pr=6166#step:6:7)6[8](https://github.com/WebAssembly/binaryen/actions/runs/7174694536/job/19536698686?pr=6166#step:6:9) for the detailed specification.
Error: Process completed with exit code 1.

https://github.com/WebAssembly/binaryen/actions/runs/7174694536/job/19536698686?pr=6166

Anyone knows what this is about?

@kripken
Copy link
Member

kripken commented Dec 11, 2023

I've never seen that before but it just happened on my PR too...

@aheejin aheejin merged commit 0b70948 into WebAssembly:main Dec 12, 2023
14 checks passed
@aheejin aheejin deleted the exnref_legacy branch December 12, 2023 06:26
aheejin added a commit to aheejin/binaryen that referenced this pull request Dec 13, 2023
…Assembly#6166)

Currently the legacy GC encoding's nullexternref encoding overlaps with
exnref's. We assume the legacy GC encoding won't be used with the exnref
for the moment and assign a random value to it to prevent the clash.
radekdoulik pushed a commit to dotnet/binaryen that referenced this pull request Jul 12, 2024
…Assembly#6166)

Currently the legacy GC encoding's nullexternref encoding overlaps with
exnref's. We assume the legacy GC encoding won't be used with the exnref
for the moment and assign a random value to it to prevent the clash.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants