Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[table64] Fix generate-dyncalls and directize under table64 #6604

Merged
merged 1 commit into from
May 18, 2024
Merged

Conversation

sbc100
Copy link
Member

@sbc100 sbc100 commented May 17, 2024

No description provided.

@sbc100 sbc100 requested review from tlively and kripken May 17, 2024 23:16
@sbc100 sbc100 force-pushed the fix_table64 branch 2 times, most recently from 8bf63b9 to 7fac78b Compare May 17, 2024 23:21
Copy link
Member

@kripken kripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These could be separate PRs as they are independent? But they are also trivial so sgtm.

The title could maybe be [Table64] Fix generate-dyncalls and directize or such?

test/lit/passes/generate-dyncalls-wasm64.wast Outdated Show resolved Hide resolved
@sbc100 sbc100 changed the title Fix generate-dyncalls and directize passed under table64 [table64] Fix generate-dyncalls and directize under table64 May 17, 2024
@sbc100 sbc100 enabled auto-merge (squash) May 17, 2024 23:37
@sbc100 sbc100 merged commit 369cddf into main May 18, 2024
13 checks passed
@sbc100 sbc100 deleted the fix_table64 branch May 18, 2024 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants