wasm2js: Add Table operations #6650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlively
approved these changes
Jun 11, 2024
| @@ -2236,28 +2235,40 @@ Ref Wasm2JSBuilder::processFunctionBody(Module* m, | |||
| visit(curr->right, EXPRESSION_RESULT)); | |||
| } | |||
| Ref visitTableGet(TableGet* curr) { | |||
| unimplemented(curr); | |||
| WASM_UNREACHABLE("unimp"); | |||
| return ValueBuilder::makeSub(ValueBuilder::makeName(FUNCTION_TABLE), | |||
There was a problem hiding this comment.
Do we validate elsewhere that the module has only one table? If not, we might want to raise an error here and on the other operations if the table is not at index 0.
There was a problem hiding this comment.
We do have an error up front about that, it is a built-in assumption throughout wasm2js.
binaryen/src/tools/wasm2js.cpp
Lines 960 to 963 in cdd94a0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TableGet, Set, Size, Grow, Fill, Copy.
Also move "null" into shared-constants, to make the code
more consistent overall.