This repository has been archived by the owner on Nov 3, 2021. It is now read-only.
Update ref.null encoding after subtyping change
#149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue WebAssembly/reference-types#69 requires that `ref.null` instructions include a reference type immediate. This concept isn't present in the bulk-memory proposal, but the encoding is (in element segment expressions). This change updates the binary and text format, but not the syntax. This is OK for now, since the only reference type allowed here is `funcref`.
rossberg
approved these changes
May 13, 2020
I originally was going to do this, but it turns out that there's a lot of new infrastructure that ref-types repo adds that bulk memory doesn't have. So I just wrote this from scratch, assuming that all we really care about is forward-compatibility with the binary and text formats. |
|
Ah, okay. I guess that's fine. The ref-types repo subsumes the bulk one at this point, so hopefully we won't have to do tricky merging of the two in the future. |
|
I did another merge from bulk into ref-types, to catch up with some recent additions to tests and overview. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue WebAssembly/reference-types#69 requires
that
ref.nullinstructions include a reference type immediate. Thisconcept isn't present in the bulk-memory proposal, but the encoding is
(in element segment expressions).
This change updates the binary and text format, but not the syntax. This
is OK for now, since the only reference type allowed here is
funcref.