Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing nonterminal definitions in the WIT EBNF #152

Closed
huwaireb opened this issue Jan 24, 2023 · 3 comments · Fixed by #170
Closed

Missing nonterminal definitions in the WIT EBNF #152

huwaireb opened this issue Jan 24, 2023 · 3 comments · Fixed by #170

Comments

@huwaireb
Copy link
Contributor

Hi,
whilst reading WIT's EBNF I noticed multiple missing nonterminal definitions, namely: nil, strlit, id

No, the Identifier section of the markdown does not constitute a nonterminal nor can act as one.

If there's reasoning behind any, I would love to know.
I'm not an expert of any kind in (E)BNF nor do I have experience writing an (E)BNF, so do feel free to correct me if I'm wrong.

Thank you

@lukewagner
Copy link
Member

Thanks for filing.

nil is supposed to be the meta-linguistic symbol for the empty string, sometimes written ϵ. Maybe we should replace it with ϵ?

#141 removes strlit as unused.

#141 documents more clearly that the definition of id in Wit is exactly the name production in the component text format.

@huwaireb
Copy link
Contributor Author

meta-linguistic symbol for the empty string,

ϵ sounds fine, however, we should probably add a "Note" alongside per-say it to make it extra clear what this symbol refers to.

As #141 was merged, this is the only? undefined nonterminal as of now.
I'll open a PR if you're fine with ϵ symbol?

@lukewagner
Copy link
Member

sgtm, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants